On Tuesday 03 Apr 2012 22:01:40 Chetan Hosmani wrote: > Hello, > > nextgens as you wanted some changes I have implemented them. I have > sent a pull request to freenet:next. > Here is the patch.
Cool. It's here: https://github.com/freenet/fred-staging/pull/88 There was some confusion about this. From your code it appears that we can just specify a 256 bit block size and the standard code will work. In which case, the new encryption is exactly the same as the old: 256-bit key, 256-bit block size, with PCFB mode on top. So you don't need the new negType. Please test this. If it works, you can use it everywhere in the code, and get rid of Rijndael, which would be pretty cool. But if so, please benchmark it first: As I mentioned, are you sure you need to initialise the cipher for each block? If it's slower in software then we need to keep the old version and only use the JCA version on startup ... I suspect that 256-bit block size isn't hardware accelerated, and certainly it isn't the standard. So the original plan was to switch to standard AES (256-bit key, 128-bit block size), which would have required using CFB (which the JCA probably implements). This isn't a criticism anyway. If we can switch to the JVM's AES implementation without even any back compatibility issues, and without a performance loss, that would be really nice. > > Also wanted some opinion on the idea "Switch from the current code to > JCA". Since I have been working and reading on this, I thought I ll > send in a proposal for this task too. Any pointers or suggestions will > be helpful. I will make a rough draft and mail that too, though there > is hardly any time left for discussion. Well, the above suggests it'd be a fairly small project, although we'd want to switch some algorithms, such as the above, at the same time. > > Thank you -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20120405/e06a42d1/attachment.pgp>
