They were also written before `Optional` was in the java spec. It feels odd to 
me to have the defaults passed around from the caller to this class just to 
reflect it back. IMHO a long term solution should just give the `Optional` back 
in all cases, and let the caller figure out what to do if there is nothing 
present. The default value would then be handled in the caller completely, or 
an exception or other case can be executed.

[ Full content available at: 
https://github.com/apache/incubator-druid/pull/5913 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to