Now, CI is green again. Can someone review this?
Summary:
* Use system zlib by default
* Changed.
* System zlib is searched by `pkg-config` or from the default system path
* Use the specified zlib when `ZLIB_HOME` is specified
* Not changed.
* If `ZLIB_HOME` is specified, system zlib isn't searched by `pkg-config`
* Use vendored zlib as fallback (no `ZLIB_HOME` and no system zlib)
* Changed. Vendored zlib was the default.
* Use system zlib as shared library
* Changed. Zlib is always used as static library.
* Use `ZLIB_HOME` zlib as static library
* Not changed.
* I gave up to use `ZLIB_HOME` zlib as shared library... There are two
problems:
* pyarrow wheel need to depend on zlib package:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/build/1.0.7630/job/sumy5r26q6ex7va1#L6772
* `python-test` is crashed only on macOS:
Backtrace: https://travis-ci.org/apache/arrow/jobs/422620234#L2677-L2696
* I don't know why...
* Use vendored zlib as static library
* Not changed.
* `after_failure` change in `.travis.yml` is a by-product of debugging crash
on macOS.
* Should I separate this change to another pull request?
* `ZLIB_LIBS` has been removed.
* Because it's not a good name and we don't use anywhere.
* It doesn't contain library paths. It contains directories that includes
library.
[ Full content available at: https://github.com/apache/arrow/pull/2483 ]
This message was relayed via gitbox.apache.org for [email protected]
