Few comments;
1) Instead of doing this in compose config
```
superset:
    image: apache/incubator-superset
```
why not change this to
```
  superset:
    build: .
```
and get rid of docker-build.sh ?

2) entrypoint. Should this have dev option or even run local with something 
this;
```
elif [ "$SUPERSET_ENV" = "local" ]; then
    superset runserver -d &
    cd /home/work/incubator-superset/superset/assets
    npm run dev
```

[ Full content available at: 
https://github.com/apache/incubator-superset/pull/4193 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to