https://github.com/apache/cordova-plugin-inappbrowser/pull/291#issuecomment-418298554
dialog is the main window(container) for of the InAppBrowsers webview.
which opens when the target='_self' or '_blank'.
dialog will be null by default, and it will be null after iab window closed 
also.(look in the code).

when the target='_system' it means open the url in system browser.
so iab will make intent to launch the url action view.
but on ionic3 native plugin also implements .show() method which is causing the 
the action to trigger
dialog.show() method. where the dialog is null. so apps will be crashed with 
NEP.
```java.lang.NullPointerException: 
  at org.apache.cordova.inappbrowser.InAppBrowser$2.run (InAppBrowser.java:281)
  at android.os.Handler.handleCallback (Handler.java:751)
  at android.os.Handler.dispatchMessage (Handler.java:95)
  at android.os.Looper.loop (Looper.java:154)
  at android.app.ActivityThread.main (ActivityThread.java:6776)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run 
(ZygoteInit.java:1518)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1408)```

wrapping the dialog.show() call with null checking will fix this problem.

[ Full content available at: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/291 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to