Creating format instance for each record is rather expensive, plus you'll be 
writing errors on each incorrect record call which will pollute the log. I was 
thinking that  you can consider having some format class instance which will be 
created before you start iterating over vectors  (`for (VectorWrapper<?> vw : 
loader) {`). This format class will accept options in constructor and have 
format method where you would pass value and minor type. Formatters for 
timestamp / date / time will be created upon necessity and stored for further 
re-use. 

[ Full content available at: https://github.com/apache/drill/pull/1449 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to