> I think we need to pick up your effort to revamp the the tools, and 1) move 
> them all into the same framework, 2) add tests & 3) add docs for each one.

let's pick up the tasks for #1000 

> If a idx file has been deleted, but ledger metadata exists, when a client 
> tries to open it and run recovery, it will see that it cannot read any 
> entries, and close the ledger as empty.

yeah. I think this is a rare corner case that we actuallly can do nothing for 
it.

> I know DLog has a force option for this, but I think it would be better to 
> provide another cli tool to allow users to mark the metadata from Closed -> 
> In recovery, and then run the recovery again.

sgtm

> It looks like we don't actually check the password on fencing, we just 
> blindly accept what the client passes in :/

not sure we really need password for fencing, since it doesn't really append 
entries. and I think in general password should be removed eventually.

[ Full content available at: https://github.com/apache/bookkeeper/pull/1642 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to