>Given that, and can we initially only enable the counter only on Shared 
>subscriptions?

 I'm agree with your comment(Especially, this might be mostly not the case in 
exclusive/failover subscriptions, where data is typically processed in order).

> This will not clean up the redelivery tracker when doing a "cumulative-ack". 
> It should be also cleaned at line 192, though for cumulative acks there might 
> be a sequence of entries to clean-up and the concurrent hash map might not be 
> a good fit (since we'd need sorted map).

If we just enable the redelivery tracker in share mode,  we don't need a sorted 
map, from client can't do cumulative-ack in share mode.




[ Full content available at: 
https://github.com/apache/incubator-pulsar/pull/2508 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to