The idea is sound, but it needs integration into the build system. The "old way" was to build the redistribution jars once and cache them on the binary server. I would not do that anymore. In the last days we learnt the hard way, that we should not rely on external systems (yes I know maven central belongs to that group).
Here is what I would do: Cover `servletjspapi` and `web.jspparser` in one PR (#906 is not enough) as they are both build similar and belong tightly together. You already identified the API modules, but they need integration into the build process. Please see `enterprise/web.core.syntax` for a similar case. In that module the taglibs are downloaded from maven central and the documentation, that is then redistributed with netbeans, is build as `external/generated-*` (see `prepare-doc` target). For `servletjspapi` you already identified the source file from maven central. These need to be filtered/unified as done in the `web.jspparser/build.xml` and a grouped license file needs to be created as in the reference module. The sources for `web.jspparser` module are also available on maven central: Jasper/JSP API: https://search.maven.org/artifact/org.glassfish.web/javax.servlet.jsp/2.3.4/jar EL: https://search.maven.org/artifact/org.glassfish.web/javax.el/2.2.6/jar Preprocessor-Util: https://search.maven.org/artifact/org.glassfish.main.common/common-util/5.0/glassfish-jar ClassLoaderUtil: https://search.maven.org/artifact/org.glassfish.main.common/glassfish-ee-api/5.0/glassfish-jar These jars need to be recombined and produces also a `generated*` file. The parser has unittests and I ask you to run them before and after your changes, to check that the parser still works. [ Full content available at: https://github.com/apache/incubator-netbeans/pull/877 ] This message was relayed via gitbox.apache.org for [email protected]
