thanks for the cleanup, see below

On Apr 25, 2008, at 5:22 AM, sdumitriu (SVN) wrote:

> Author: sdumitriu
> Date: 2008-04-25 05:22:47 +0200 (Fri, 25 Apr 2008)
> New Revision: 9369
>
> Modified:
>   xwiki-platform/core/trunk/xwiki-core/pom.xml
> Log:
> XWIKI-2337: Move common dependencies versions to the parent pom  
> dependencyManagement section
> XWIKI-2338: Upgrade some commons packages
> Upgrade the core pom

[snip]

>     <!-- VMA: I'm not sure if we have the right to distribute this  
> jar. It's not on the central repository because
>          of licensing issues. -->
> +    <!-- Sergiu: No, we cannot redistribute it. And we definitely  
> shouldn't put it in our repo.
> +         We can redistribute version 1.1, but we should make users  
> approve their License Agreement.
> +         Can we drop this completely? Why is it needed? -->

it's needed for sending mail. Sun was supposed to provide new  
redistributable licenses with new releases of their jars. We need to  
check if it's been done.

>
> +    <!-- TODO: Version 1.1 is available, should we upgrade? -->

that means upgrading mail. Yes we should especially if the license is  
good now.

>
>     <dependency>
>       <groupId>javax.transaction</groupId>
>       <artifactId>jta</artifactId>
> @@ -136,6 +141,7 @@
>     <!-- There's only a 2.2.9.1 version of jgroups on the central  
> repository
>          (http://repo1.maven.org/maven2/jgroups/jgroups-all/).  
> Upload a newer version
>          
> (http://sourceforge.net/project/showfiles.php?group_id=6081&package_id=94868 
> ). -->
> +    <!-- TODO: 2.4.1 is there now, although 2.6.2 is released on  
> Sourceforge; should we upgrade? -->

This is used by oscache for clustering I think. I'd not upgrade unless  
you have verified that clustering works fine before, then upgrade then  
test again.

[snip]

> +
> +    <!-- Things that should probably be removed -->
> +    <dependency>
> +      <groupId>org.apache.velocity</groupId>
> +      <artifactId>velocity-tools</artifactId>
> +      <version>1.3</version>
> +    </dependency>

why do you say that? We're using it.

> +    <dependency>
> +      <groupId>joda-time</groupId>
> +      <artifactId>joda-time</artifactId>
> +      <version>1.4</version>
> +    </dependency>
> +    <dependency>
> +      <groupId>backport-util-concurrent</groupId>
> +      <artifactId>backport-util-concurrent</artifactId>
> +      <version>3.0</version>
> +    </dependency>
>   </dependencies>
>   <build>
>     <plugins>

Thanks
-Vincent


_______________________________________________
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to