Hi devs, Before Jerome applies the patch, I need to make a small change regarding the following question:
Do we include in the feed by default the entire description/content/summary of a feed entry or only the first N characters? There is a ContentLength length property that could have by default the -1 value, meaning the entire content, or N value, meaning the first N characters. For instance, in the current XWiki.BlogRssCode, the default length is 400 characters (so not the entire content). Thanks, Marius > > On Jun 24, 2008, at 2:05 AM, Jerome Velociter wrote: > >> It's tomorrow already and I still have an issue with the patch. I need >> Marius's help with it. We'll see in the morning if it's big an issue >> or >> not, if it is, let's leave the patch for 1.6... > > No, we could include it in RC1 since it's completely decoupled and not > used in core. > > Thanks > -Vincent > > >>> Depends how fast you can apply and *test* it, ideally with automated >>> tests. >>> >>> If it can be done today then +1 otherwise, -0. >>> >>> I wonder why this was not raised before. It's not like it's something >>> new. We should be more proactive. >>> >>> Thanks >>> -Vincent >>> >>> On Jun 23, 2008, at 2:46 PM, Jerome Velociter wrote: >>> >>>> Hello devs, >>>> >>>> I would like to propose to apply Marius's patch attached to >>>> http://jira.xwiki.org/jira/browse/XWIKI-2149 ("Extend the FeedPlugin >>>> to >>>> allow the creation of RSS/Atom feeds from any source"), in order to >>>> have >>>> it available in 1.5. >>>> >>>> The patch comes with unit tests, and does not change existing code >>>> (it >>>> only adds new classes in the feed plugin/introduce a new util >>>> class in >>>> com.xpn.xwiki.util, + new APIs in the feed plugin API). I believe it >>>> is >>>> not harmful. >>>> >>>> I'm +1 for it, and dedicated to apply it if we agree we want it. >>>> >>>> Jerome. >>>> >>>> (btw, this is a prerequisite for XE-240: Improve XE RSS feeds, >>>> marked as >>>> fix for M2) > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
