Asiri Rathnayake wrote:
> Hi Vincent,
> 
> Ok, will revert those changes.
> 
> Btw, why I tried to use static methods instead of separate classes is
> because those classes seemed to be doing very little. I mean those classes
> were utilized like,
> 
> <code>
>         new TagRemoveFilter().doFilter(document);
>         new UnderlineLinkFilter().filter(document);
>         new XWikiSyntaxEscapeFilter().doFilter(document);
>         new ImageTagFilter().doFilter(document);
>         new PinLiFilter().doFilter(document);
>         new EmptyLinkFilter().doFilter(document);
> </code>
> 
> That's all. Something didn't look right to me. And also it seems to clutter
> the functionality into a lots of tiny classes.
> 

Listing implementations is wrong. Why not use components?

-- 
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to