asiri (SVN) wrote:
> Author: asiri
> Date: 2009-04-03 10:43:01 +0200 (Fri, 03 Apr 2009)
> New Revision: 18222
> 
> Modified:
>    
> platform/core/trunk/xwiki-xml/src/main/java/org/xwiki/xml/internal/html/filter/FontFilter.java
>    
> platform/core/trunk/xwiki-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java
> Log:
> XWIKI-3494: Font tag is not cleaned properly.
> 
> * Fixed.

> +    public FontFilter()
> +    {
> +        fontSizeMap = new HashMap<String, String>();
> +        fontSizeMap.put("1", "8");
> +        fontSizeMap.put("2", "10");
> +        fontSizeMap.put("3", "12");
> +        fontSizeMap.put("4", "14");
> +        fontSizeMap.put("5", "18");
> +        fontSizeMap.put("6", "24");
> +        fontSizeMap.put("7", "36");
> +    }

Asiri, using pt as font sizes is not good, because it will not fit well 
with custom skins. It is better to use relative font sizes, using either 
em or %, like:

font size=1 => font-size: 0.6em; or: font-size: 60%;

This way, fonts will be made larger or smaller compared to the current 
skin's normal font size.
-- 
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to