On Sep 29, 2009, at 18:01, Thomas Mortagne wrote: > On Tue, Sep 29, 2009 at 17:11, Vincent Massol <[email protected]> > wrote: >> Hi, >> >> I'd like to add: >> * List<AttachmentName> getAttachments(DocumentName documentName) >> throws Exception; >> * byte[] getAttachmentContent(AttachmentName attachmentName) throws >> Exception; > > I would prefer > > InputStream getAttachmentContent(AttachmentName attachmentName) throws > Exception; > > instead which is more generic.
I has a patch for the core that would require that form, so I really prefer you use that one too even if my patch does not touch the bridge part for now. (The patch is really coming, it is just a matter of time, code is in production without a glitch since a while now) > >> >> And deprecate: >> * List<String> getAttachmentURLs(DocumentName documentName, boolean >> isFullURL) throws Exception; >> * byte[] getAttachmentContent(String documentName, String >> attachmentName) throws Exception; >> >> I need this fix a bug in the Script Macro when using jarurls >> parameter >> (for 2.0.1). >> >> Here's my +1 > > +1 for the general change strings to proper objects. > >> >> Thanks >> -Vincent >> >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs >> > > > > -- > Thomas Mortagne > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
