On Jan 25, 2010, at 9:46 PM, Sergiu Dumitriu wrote:
> On 01/25/2010 09:08 PM, vmassol (SVN) wrote:
>> Author: vmassol
>> Date: 2010-01-25 21:08:08 +0100 (Mon, 25 Jan 2010)
>> New Revision: 26377
>>
>> Added:
>>
>> platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/test/AbstractBridgedComponentTestCase.java
>> Modified:
>>
>> platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java
>>
>> platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/store/XWikiHibernateStoreTest.java
>> Log:
>> XWIKI-2758: PostgreSQL exceptions unusable
>
> Forgot to give credit.
Yes. I was applying my own fix and then applied Frits' suggestion later on and
I forgot. Fixed in the new commit.
>> Modified:
>> platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java
>> ===================================================================
>> ---
>> platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java
>> 2010-01-25 18:38:18 UTC (rev 26376)
>> +++
>> platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java
>> 2010-01-25 20:08:08 UTC (rev 26377)
>
> You should cleanup this commented code:
Yes thanks for catching it.
>
>> +/*
>> + if (t.getCause() instanceof BatchUpdateException
>> +&& ((BatchUpdateException) t.getCause()).getNextException() != null) {
>> + final BatchUpdateException bue = (BatchUpdateException)
>> t.getCause();
>> + return bue.getNextException().getMessage();
>> + }
>> +
>> + return t.getMessage();
>> + */
>> + return sb.toString();
>> + }
>
>
> Are you sure this was supposed to be part of this commit?
Yes it is (I refactored the test to move it to JUnit 4.x and JMock 2.x before
adding a new unit test).
Thanks
-Vincent
>
>> Added:
>> platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/test/AbstractBridgedComponentTestCase.java
>> ===================================================================
>> ---
>> platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/test/AbstractBridgedComponentTestCase.java
>> (rev 0)
>> +++
>> platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/test/AbstractBridgedComponentTestCase.java
>> 2010-01-25 20:08:08 UTC (rev 26377)
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
