Hi devs, I would so much like to commit XWIKI-4775, at least in 2.3. So, we for the separators, so far we have:
1/ wiki:Space.Page^objectName#property 1 +1 (I recorded Vincent here), 1 -0.5, 1 -1 2/ wiki:Space.Page:objectName.property 1 -1, 1 +1 3/ wiki:Space.Page^objectName;property 1 +0.5, my +1 which I will change now 4/ wiki:Space.Page^objectName.property 2 +1 5/ wiki:Space.Page^objectName^property 1 +1 My +1 goes for 4/ which I will commit soon if nobody has anything against it. Re-explanation of the thing: As a result of the discussion at http://markmail.org/thread/uj34lvnjgrnlf6vm and some other live discussion, we concluded that we would implement the objects and object properties references _as if_ every entity had a free name (unique, human readable string name to identify it among all other entities of the same type in the same context). However, for the moment we don't have a good approach for how _exactly_ to name objects, so we won't implement a specific way to name them, we'd have the support for generic object references but not the names themselves, which would be the responsibility of the application _actually_ using the object references (none in core, ftm, only annotations on sandbox). To get a flavour about how this would happen at this point, take a look at the way IndexedObjectReference [1] in the annotation references module extends the ObjectReference[2] in the patched model, to implement a specific way of naming. Now, in order to actually commit XWIKI-4775, the support for generic object references (with unspecified name), we need to agree on a separator, which would be harder to change afterwards, when we decide on the actual name. [1] http://svn.xwiki.org/svnroot/xwiki/contrib/sandbox/xwiki-annotation-parent/xwiki-annotation-reference/src/main/java/org/xwiki/annotation/reference/IndexedObjectReference.java [2] http://svn.xwiki.org/svnroot/xwiki/contrib/sandbox/xwiki-annotation-parent/xwiki-annotation-model-backport/src/main/java/org/xwiki/model/reference/ObjectReference.java Thanks a lot for the help, Anca On 01/25/2010 10:55 PM, Anca Luca wrote: > Hi all, > > I would like to go ahead with committing > http://jira.xwiki.org/jira/browse/XWIKI-4775 before the 2.2 final release > (because I would like annotations to work as clean as possible on 2.2 final). > > In order to do that, we need to agree on a set of separators for the object > name > and property name. > There have been the following proposals so far: > > A wiki:Space.Page^objectName#property > B wiki:Space.Page^objectName$property > > which has received some votes in http://markmail.org/thread/uihq4mmwgaufbcz6 > but > I personally would stay away from # and $ separators since they're reserved > characters in velocity scripting language and it might be uncomfortable for > using refs in scripts. > > Also, we had: > > C wiki:Space.Page^objectName;property > > and also: > > D wiki:Space.Page:objectName.property > > Which one would you prefer? Any other proposals? > > Any separator should be easy to implement, and roughly anything could be used > as > a separator (so feel free to propose). > > Note that there is an alternative to this, to make annotations implementable > on > 2.2: only add the two entity types (Object and Object Property) along with > making the string serializer and string resolver extensible so one could add > its > own separators for the 2 new types. > > WDYT? > > Thanks, > Anca > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
