On 03/23/2010 05:19 AM, cjdelisle (SVN) wrote:
> Author: cjdelisle
> Date: 2010-03-23 05:19:38 +0100 (Tue, 23 Mar 2010)
> New Revision: 27798
>
> Modified:
>
> platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/validation/livevalidation.css
> Log:
> XWIKI-5038: With Toucan skin, LiveValidation borders cause text below a field
> to shift when field is clicked on. - Removed field borders from stylesheet.
This change means that upgrading to a future version will be harder. So,
the question is:
Do we override the style in our own skins, causing bigger files, but
keeping it simple to upgrade in the future, or do we fully adopt
LiveValidation and hack it as much as we want, improving it even further?
Personally I vote for the second.
>
> Modified:
> platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/validation/livevalidation.css
> ===================================================================
> ---
> platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/validation/livevalidation.css
> 2010-03-23 00:30:42 UTC (rev 27797)
> +++
> platform/web/trunk/standard/src/main/webapp/resources/uicomponents/widgets/validation/livevalidation.css
> 2010-03-23 04:19:38 UTC (rev 27798)
> @@ -10,20 +10,4 @@
> .LV_invalid {
> color:#CC0000;
> }
> -
> -.LV_valid_field,
> -input.LV_valid_field:hover,
> -input.LV_valid_field:active,
> -textarea.LV_valid_field:hover,
> -textarea.LV_valid_field:active {
> - border: 1px solid #00CC00;
> -}
> -
> -.LV_invalid_field,
> -input.LV_invalid_field:hover,
> -input.LV_invalid_field:active,
> -textarea.LV_invalid_field:hover,
> -textarea.LV_invalid_field:active {
> - border: 1px solid #CC0000;
> -}
>
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
