> Hi devs, > Hello Ana,
> I wanted to show you what work has been done until now on the Google > Gadgets Integration, talk a bit about the next steps and ask for > feedback. I put up the gadgets work on the incubator, so you can take > a quick look. > [snip] > > SVN: > - https://svn.xwiki.org/svnroot/xwiki/contrib/sandbox/xwiki-gadgets/ > (Java Components) Quick feedback on the code in xwiki-gadgets/ (I only read it so far, I did not run it yet) * You can get rid of the VelocityContextInitializers classes, now XWiki supports script services. Just implement the ScriptService component role with your service name as a hint and you will have access to the binding in scripts under $services.yourServiceName (so gadgets and macros in your case). * Some classes are missing a minimal javadoc, to describe what the classes does. For example I opened the UserPrefs class and had no clue what preferences it was about (By the way I think you could go for the full name : UserPreferences rather than using abbrs.) What you can do is enable the checkstyle plugin in your build; this way you are forced to document as you write your code and not postpone it until the moment when you have too much to document and it becomes discouraging. It also can help detect early certain design issues. Jerome. > - https://svn.xwiki.org/svnroot/xwiki/contrib/sandbox/gadgets/ (XAR) > > Thanks for the feedback, > Anamaria > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
