On May 17, 2010, at 2:38 PM, tmortagne (SVN) wrote:

> Author: tmortagne
> Date: 2010-05-17 14:38:00 +0200 (Mon, 17 May 2010)
> New Revision: 28930
> 
> Modified:
>   
> platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm
> Log:
> XTCONFRES-48: Add configuration for document rendering cache
> 
> Modified: 
> platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm
> ===================================================================
> --- 
> platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm
>    2010-05-17 12:33:16 UTC (rev 28929)
> +++ 
> platform/xwiki-tools/trunk/xwiki-configuration-resources/src/main/resources/xwiki.properties.vm
>    2010-05-17 12:38:00 UTC (rev 28930)
> @@ -12,6 +12,27 @@
> #-# Default value is xwiki/2.0.
> # core.defaultDocumentSyntax = xwiki/1.0
> 
> +#-# [Since 2.4M1]
> +#-# Indicate if the rendering cache is enabled.
> +#-# Default value is false.
> +# core.renderingcache.enabled=true
> +
> +#-# [Since 2.4M1]
> +#-# A list of JAVA regex based patterns matching full documents reference.

Is this param about listing documents that are cached and for which the 
rendered result is cached? If so I think we should mention this in the 
documentation.

Also JAVA --> Java ? (uppercase would mean that it's an acronym, which it 
isn't).

"JAVA regex based" --> "Java regex" ?

> +# core.renderingcache.documents=wiki:Space\.Page
> +# core.renderingcache.documents=wiki:Space\..*
> +
> +#-# [Since 2.4M1]
> +#-# Indicate after which duration (in seconds) a data should be removed from 
> the cache when not used.

"The time after which data should be removed from the cache when not used."

> +#-# Default value is 300 (5 min).
> +# core.renderingcache.duration=300
> +
> +#-# [Since 2.4M1]
> +#-# The size of the rendering cache. Not that its not the number of document 
> cached but the number of results cached.

"its" --> "it's"
"document" --> "documents"
"document cached" --> "cached documents"
"results cached" --> "cached results"

> +#-# For a same document a variety of result is produced because each action, 
> language and request query string produce unique result.

I would put this in parenthesis to mention that it's an explanation of 
"results" above.

Also:

"For a same document a variety of result is produced because each action, 
language and request query string produce unique result."
-->
"For a single document several cache entries are created, because each action, 
language and request query string produces a unique rendering result."

> +#-# Default value is 100.
> +# core.renderingcache.size=100
> +
> #-------------------------------------------------------------------------------------
> # Rendering
> #-------------------------------------------------------------------------------------
> 
Thanks
-Vincent

_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to