On 05/22/2010 07:53 PM, Denis Gervalle wrote: > On Sat, May 22, 2010 at 16:34, Marius Dumitru Florea< > [email protected]> wrote: > >> Hi Denis, >> >> On 05/21/2010 04:44 PM, Denis Gervalle wrote: >> >> [snip] >> >>> a WYSIWYG editor that does not allow simple left/center/right alignment >> >> Some of the WYSIWYG editor features (including text alignment) are not >> enabled by default in the standard XWiki Enterprise distribution. All >> features are listed on >> http://platform.xwiki.org/xwiki/bin/view/Features/WysiwygEditor . >> > > Nice to know, I was not aware of that, since I have not use the editor much > myself since my browser is not officially supported.
> But, could you explains why text alignement is not enable in XE, this seems > too me basic requirement for any user, so why hiding it ? I think the reason for disabling such features by default in XE is that the formatting options they expose are most of the time not web-friendly. Besides that, we encourage wiki users to focus more on the content and less on the text formatting. Using multiple fonts (some of which weren't made for the web but for print), text alignments and colors on the same wiki page makes its content hard to read and breaks the L&F consistency. This is also one of the reasons for having the option to remove all the styles when importing office content. This is just my opinion. We had a discussion at some point but I don't remember the rest of the arguments. We can (re)discuss this in a different thread. > I will be able to enable it, but I may imagine not all XE administrator will > find it so easy. > > >> >> [snip] >> >>> As we all do, and I am also curious to know what others have to say on >> our >>> discussion. >> >> I agree with Vincent when he says that the most difficult part is >> setting up the test environment and the test framework. Writing tests >> > > This is why I currently does not have provide test for the livetable. > > >> afterwards is easy and gives me a lot of confidence. Thus I think we >> > > Yes, this would be nice to have. > > >> should focus on what is the best way to test each part of XWiki rather >> than on arguing if making a feature available to the user early is >> better than waiting till we have enough tests to be confident that that >> feature meets a desired level of quality. >> > > I agree, but we should also agree on our quality requirement. On this, it > seems Vincent has a higher requirement level then I have. > > >> Denis, regarding testing live table features that are not present >> anywhere in XE's documents, you can use the test setup to insert a >> custom live table in a wiki page. For the WYSIWYG editor we enable all >> the editing features during test setup to be able to test them all >> (including alignment ;) ). For specific interactions that are not used >> yet on XE but only on client projects we insert the editor in a wiki >> page with custom configuration. >> > > I am currently far from thinking about detaikls of tests setup, but I know > there are some solutions. What I have just said is that for proper testing, > we also need to be able to test all supported browser, else we will miss the > most common problem of UI testing which is browser incompatibilities. I agree. Sadly, we are currently running the functional tests only on FF3.5. What's worse it that most of the WYSIWYG editor Selenium tests (and maybe others) won't run in IE even if we setup a dedicated build agent for this because these tests use browser specific JavaScript code that doesn't work in IE (e.g. code to place the caret at a given position in the rich text area during a test). Thanks, Marius > > Denis > > >> Thanks, >> Marius >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs >> > > > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
