On Mon, Jun 21, 2010 at 13:24, Marius Dumitru Florea < [email protected]> wrote:
> Hi Denis, > > On 06/21/2010 01:55 PM, Denis Gervalle wrote: > > Hi Devs, > > > > Currently we do not have any code style specification for imports. To > > improve clarity of our commits, I propose that we decide once for all how > we > > would like to have imports. Of course, normalisation of existing code > will > > come with normal commit, I do not intend to update it only for that. > > Are you saying that > > http://svn.xwiki.org/svnroot/xwiki/platform/xwiki-tools/trunk/xwiki-verification-resources/src/main/resources/codestyle-eclipse.xml > doesn't include information about import styles? > Sorry, I do not have Eclipse, maybe Thomas could precise this point. What I am saying is that we do not have any written code style for that, and we use the default of the IDE. > > > > > Currently, > > > > Eclipse does java.*, org.*, com.* separated by blank lines > > IntelliJ IDEA does com.*,org.* together, than a blank line and java.* > > So you're saying that codestyle-eclipse.xml and codestyle-idea.xml are > not consistent? > There are not, probably because we have never look at it and their defaults differ. > > > Old existing code has there own ordering... > > > > I propose the following style: > > > > import java.* > > > > import org.* > > import com.* > > import<anything else> > > > > import org.xwiki.* > > import com.xpn.* > > > > import static<any> > > > > If we agree on this, necessary IDE setup for both Eclipse and IntelliJ > > should be prepare/updated. I will take IntelliJ in charge, a volunteer > for > > Eclipse is welcome (Thomas?) > > You mean update codestyle-eclipse.xml and codestyle-idea.xml ? > Yes, and if this is not part of codestyle-eclipse, provide what is required to have both IDE in sync. Denis > > Thanks, > Marius > > > > > WDYT ? > > > > Denis > > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
