On 06/21/2010 12:03 PM, Jerome Velociter wrote: > > ----- "Sergiu Dumitriu"<[email protected]> wrote: > >> On 06/21/2010 10:36 AM, Vincent Massol wrote: >>> >>> On Jun 21, 2010, at 10:24 AM, sdumitriu (SVN) wrote: >>> >>>> Author: sdumitriu >>>> Date: 2010-06-21 10:24:46 +0200 (Mon, 21 Jun 2010) >>>> New Revision: 29596 >>>> >>>> Modified: >>>> >> platform/web/trunk/standard/src/main/webapp/resources/js/prototype/prototype.js >>>> Log: >>>> XWIKI-4183: Improve page load speeds via parallel JavaScript >> download >>>> Fixed most race condition failures occuring in IE >>>> >>>> Modified: >> platform/web/trunk/standard/src/main/webapp/resources/js/prototype/prototype.js >>>> >> =================================================================== >>>> --- >> platform/web/trunk/standard/src/main/webapp/resources/js/prototype/prototype.js >> 2010-06-21 08:24:35 UTC (rev 29595) >>>> +++ >> platform/web/trunk/standard/src/main/webapp/resources/js/prototype/prototype.js >> 2010-06-21 08:24:46 UTC (rev 29596) >>>> @@ -4687,8 +4687,11 @@ >>>> document.addEventListener('DOMContentLoaded', >> fireContentLoadedEvent, false); >>>> } else { >>>> document.observe('readystatechange', checkReadyState); >>>> + // Disabled in XWiki since it conflicts with defered scripts >>>> + /* >>>> if (window == top) >>>> timer = pollDoScroll.defer(); >>>> + */ >>> >>> So we'll loose this change (ie we'll have to remember it) when we >> upgrade to a new version of prototype? >> >> Trying to convince them to fix it. > > Also, will XWiki work without this modified version of prototype ? I think > curriki is loading prototype from the googleapis.com CDN.
It fails only in IE (6-8), and only when the page is loaded without a cache. Loading from the cache works. > If it breaks, is there an easy to disable parallel loading for the wiki ? For all scripts, not yet. You can manually exclude scripts. > Jerome. > >> >> https://prototype.lighthouseapp.com/projects/8886-prototype/tickets/1079-the-domloaded-event-is-fired-before-defered-scripts-are-executed -- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
