On Fri, May 4, 2012 at 5:55 PM, Marius Dumitru Florea <[email protected]> wrote: > On Fri, May 4, 2012 at 1:06 PM, Jean-Vincent Drean <[email protected]> wrote: >> On Wed, May 2, 2012 at 6:28 PM, Jean-Vincent Drean <[email protected]> wrote: >>> Hi, >>> >>> >>> In addition to QueryFilter#filterStatement(), this method would be >>> called from the QueryExecutor and it would allow the filter to mofidy >>> the result list of a query. >>> >> >> As Thomas pointed out in a recent discussion the fact that the result >> list can be heavily modified by the filter (and indeed I already have >> a filter transforming List<Object[]> to List<String>) doesn't match >> with the API signature. I'd like to modify the proposal: >> >> ====================8<==================== >> /** >> * Filter a list of query results. The result list can be returned >> without modification. >> * >> * @param results the original result list. >> * @return a filtered result list. >> */ > >> List filterResults(List results); > > List<?> filterResults(List<?> results); > > to avoid the warnings? >
We could but I don't think we need to. We're are already suppressing this warning in the query executor because of the Query#list() method which returns a plain List. https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/hibernate/query/HqlQueryExecutor.java#L98 > Thanks, > Marius > >> ====================8<==================== >> >> >> -- >> Jean-Vincent Drean, >> XWiki. >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs -- Jean-Vincent Drean, XWiki. _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
