On Fri, May 4, 2012 at 6:49 PM, Marius Dumitru Florea <[email protected]> wrote: > On Fri, May 4, 2012 at 11:28 AM, Ecaterina Moraru (Valica) > <[email protected]> wrote: >> Hi, >> >> IMO this is related to the "Improve edit mode" proposal >> http://incubator.myxwiki.org/xwiki/bin/view/Improvements/ImprovedEdit >> where we try to remove all panels from the edit mode and integrate the >> functionality more close to the content. >> >> Adding and deleting tags is done from the #xdocFooter, so there is no need >> to duplicate it here. >> IMO the problem is the documentation that needs updated. > > Then we should also remove tagedit.vm (which is very buggy in its > current state and thus unusable) and the style sheet extension related > to tag edit from Document Information panel.
I'll also update the documentation for Tag application [1]. We won't support "Tagging a page in structured mode" [2] as it is called there.. Thanks, Marius [1] http://extensions.xwiki.org/xwiki/bin/view/Extension/Tag+Application [2] http://extensions.xwiki.org/xwiki/bin/view/Extension/Tag+Application#HTaggingapageinstructuredmode > > Thanks, > Marius > >> >> Thanks, >> Caty >> >> On Fri, May 4, 2012 at 10:32 AM, Marius Dumitru Florea < >> [email protected]> wrote: >> >>> Hi devs, >>> >>> Until recently the Document Information panel was letting the users >>> edit the document tags, as indicated on >>> http://extensions.xwiki.org/xwiki/bin/view/Extension/Tag+Application . >>> Sergiu removed this feature in >>> >>> https://github.com/xwiki/xwiki-platform/commit/2e4b54267b9bf4048c14fdf14b6a0a65236aabad#L6L429 >>> . The commit message doesn't mention this and since the style sheet >>> extension object related to tags edit was kept (and is still present >>> in the current version) I though initially that this was a mistake. >>> After I put it back locally I discovered the feature wasn't working >>> well. I've made this changes http://pastebin.com/11ewzxYz to fix some >>> of them but there is still one big issue: you can't remove all tags >>> because >>> https://github.com/xwiki/xwiki-platform/commit/2d2d3b2de71b6de5a078ffccec63d9cd58d6df9d#L0R2884 >>> which fixes http://jira.xwiki.org/browse/XWIKI-2545 . >>> >>> Do we want to keep/maintain this feature? There is at least one users >>> that requested it. See >>> http://lists.xwiki.org/pipermail/users/2012-May/022729.html . >>> >>> Thanks, >>> Marius >>> _______________________________________________ >>> devs mailing list >>> [email protected] >>> http://lists.xwiki.org/mailman/listinfo/devs >>> >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
