On 12/19/2012 06:48 PM, Marius Dumitru Florea wrote: > On Thu, Dec 20, 2012 at 1:23 AM, Eduard Moraru <[email protected]> wrote: >> Marius, but why run even the Unit tests? The build is already tested >> continuously (both unit and functional), why waste more time during the >> release? > > Just to be safe. Mistakes can always occur and the time gained by > skipping the unit tests (btw, do you have an estimate of the time we > gain by skipping unit tests?) is less important IMO than the > insecurity we introduce by skipping the unit tests. Let's see what > others think.
I'm -ε for skipping unit tests, however I strongly believe that we should switch to staged releases from automatic CI builds, where the release is just a build promotion, and in this case all tests should be enabled since the build is automatic and happens before the release process starts. Until then, I think that safety is more important, given that unit tests actually take a lot less than integration tests. > Thanks, > Marius > >> >> Thanks, >> Eduard >> >> >> On Thu, Dec 20, 2012 at 12:18 AM, Marius Dumitru Florea < >> [email protected]> wrote: >> >>> -1 for unit tests (they shouldn't be flickering) >>> +1 for functional tests >>> >>> Thanks, >>> Marius >>> >>> On Wed, Dec 19, 2012 at 7:29 PM, Eduard Moraru <[email protected]> >>> wrote: >>>> Hi devs, >>>> >>>> Well, the subject pretty much sums it up. I am proposing to skip any >>>> testing while building a release, since that is the job of the CI >>>> infrastructure and, it happened more than once for the build of the >>> release >>>> to fail because of a flickering test. This is really annoying for a >>> release >>>> manager that has to start over the entire build (since right now it's a >>>> real pain to alter the scripts to continue the build). >>>> >>>> Besides this, tests (specially the functional ones added into platform) >>>> uselessly delay the build, thus, the release. >>>> >>>> Note: We are already skipping tests for enterprise and manager. This vote >>>> is actually about skipping tests for commons, rendering and platform as >>>> well. >>>> >>>> Here's my +1. >>>> >>>> Thanks, >>>> Eduard -- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
