On Mon, Aug 26, 2013 at 4:29 PM, Vincent Massol <[email protected]> wrote: > Hi, > > Just FTR Marius is on holidays till the end of the week… ;) > > Thanks > -Vincent > > On Aug 23, 2013, at 1:24 PM, jhaimerl <[email protected]> wrote: > >> Hi Marius, >>
>> I'm back on working on this. Maybe you can help me getting-in and tell me >> something about this mechanism (http://snag.gy/OVUoR.jpg). How are the >> plugins published at this point? The list of available plugins is hard-coded unfortunately both in the WYSIWYG editor code [1] and in the WYSIWYG editor administration section [2]. >> >> I set up eclipse to debug the java code with the browser gwt dev plugin. >> Maybe it could be useful for someone, would you like that I document it >> somewhere? Could be a new "Debugging" section on the WYSIWYG Editor module page [3] Hope this helps, Marius [1] https://github.com/xwiki/xwiki-platform/blob/xwiki-platform-5.2-milestone-1/xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-client/src/main/java/org/xwiki/gwt/wysiwyg/client/WysiwygEditorFactory.java#L83 [2] https://github.com/xwiki/xwiki-platform/blob/xwiki-platform-5.2-milestone-1/xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-ui/src/main/resources/XWiki/WysiwygEditorConfigSheet.xml#L878 [3] http://extensions.xwiki.org/xwiki/bin/view/Extension/WYSIWYG+Editor+Module >> >> >> Marius Dumitru Florea wrote >>> Hi Richard, >>> >>> On Thu, Jun 6, 2013 at 9:02 AM, rhierlmeier < >> >>> rhierlmeier@ >> >>> > wrote: >>>> Hi, >>>> >>>> we studied the source code of the gwt wysiwyg editor but we found no >>>> official way to integrate an custom plugin. >>> >>> Yes, right now all the plugins are written in Java (GWT) and adding a >>> new plugin requires rebuilding the editor. We've been wanting to add >>> support for (dynamic) JavaScript plugins for some time but we didn't >>> because we focused on other things. >>> >>>> >>>> We have the impression that it should be relatively easy to establish a >>>> public API for registering customer plugins. >>>> >>>> The customer plugin would be delivered as javascript code with a global >>>> javascript function that implements PluginFactory interface. >>>> >>>> The WysiwygEditorConfigClass would have an addition property >>>> customerPlugins, containing a comma seperate list of strings of the >>>> PluginFactory method names. >>>> >>> >>>> Do you think that this is doable? >>> >>> Yes. I would write a generic JavaScriptPluginFactory (implementing >>> PluginFactory) and JavaScriptPlugin (implementing Plugin) to serve as >>> a bridge between GWT and plugins written in native JavaScript. >>> WysiwygEditorFactory would then iterate the list of JavaScript plugin >>> names and create a JavaScriptPluginFactory instance for each, passing >>> the name. The factory would simply create a new JavaScriptPlugin >>> instance, forwarding the name. The plugin would access the global >>> JavaScript variable with the given name and take from it the data >>> needed to implement the Plugin interface. Of course, you need to >>> define an "interface" for the JavaScript plugins, and they have to bee >>> able to add event listeners like a GWT plugin. >>> >>> A contribution on this topic would be more than welcomed. >>> >>> Thanks, >>> Marius >>> >>>> >>>> Regards >>>> >>>> Richard > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
