Hi devs, We’re Thursday and Thursday is XWiki Day! :)
I’d like to propose that we do our first PR Review Day today. The goal is to review all the JIRA issues that have patches or PRs in them (http://jira.xwiki.org/secure/IssueNavigator.jspa?reset=true&mode=hide&jqlQuery=%28keywords+%7E+patch+OR+labels+in+%28patch%29+OR+%22Pull+Request+Status%22+is+not+EMPTY%29+AND+status+in+%28Open%2C+%22In+Progress%22%2C+Reopened%29+AND+resolution+%3D+Unresolved) and: - apply them if possible - comment on them if something is missing/not right - set the proper “Pull Request Status” field value: Awaiting Committer Feedback, Awaiting Contributor Feedback, None - ping the contributor if we’ve already asked for some info and we didn’t get it - if some PR are almost good then spend the extra time to finish them to allow applying the PR Process: - when you start reviewing a PR please assign it to yourself to set the lock on it - when you’re done, if the issue wasn’t closed, then unassign yourself Please record: - how many issues you’ve reviewed - how many PRs you’ve applied WDYT? Let’s do it! :) Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
