On 17 Jun 2015 at 10:04:00, Jean SIMARD (jean.sim...@xwiki.com) wrote:
On 17/06/2015 10:02, vinc...@massol.net wrote:
> We also need to do the same for:
> public DocumentReference createDocumentReference(String wiki, String space,
> String page)
>
>
> FTR:
>
> * 1300 places to fix in Java using new DocumentReference(wiki, space, page)
> * 90 places using $services.model.createDocumentReference(…) in *.vm
> * 140 places using $services.model.createDocumentReference(…) in *.xml
>
> That’s a lot…
Yes but IntelliJ and sed are your friends ;-)
Unfortunately not that simple… there’s no automatic fix.
-Vincent
>
> Thanks
> -Vincent
>
> On 17 Jun 2015 at 09:57:38, vinc...@massol.net (vinc...@massol.net) wrote:
>
> Hi devs,
>
> Ideally I believe we should remove the new DocumentReference(wiki, space,
> page) constructor. However, for backward compatibility we cannot do this.
>
> So I propose that we start by deprecating it as we should now always use the
> new DocumentReference(wiki, List<String> spaces, page) one.
>
> What I suggest we do to flesh out all issues related to Nested Spaces, is to
> start by removing it on our dev machines to find out places to fix.
>
> Then once we’ve progressed enough to not break everything, I suggest we move
> it to Legacy with an Aspect to make sure we don’t use it anymore.
>
> WDYT?
>
> Thanks
> -Vincent
>
>
> _______________________________________________
> devs mailing list
> devs@xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs
>
--
Jean Simard
jean.sim...@xwiki.com
Research engineer at XWiki SAS
http://www.xwiki.com
Committer on the XWiki.org project
http://www.xwiki.org
_______________________________________________
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs@xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
