On Wed, Jul 5, 2017 at 5:32 PM, Ecaterina Moraru (Valica) <[email protected]> wrote: > in theory we should make optional as many as possible, except the ones that > are mandatory :) sounds obvious right? :) > > for example, are the macros re-added in XWIKI-14485 really mandatory? Like > the formula, rss, container, etc.
I'm only talking about the flavor here and nothing else. Those macros are part of the WAR right now so that's a different subject. > > ideally mandatory dependencies should be the ones that should for the base > flavor, that stay at the core of any flavor. > > For me is not clear how we will mark the dependencies that are optional, > but that's another topic. Yes and you can find another mail about that :) > > From the list you gave: > > On Wed, Jul 5, 2017 at 6:00 PM, Thomas Mortagne <[email protected]> > wrote: > >> Hi everyone, >> >> I just implemented https://jira.xwiki.org/browse/XCOMMONS-1229 which >> allows to indicate that a dependency will be installed by default but >> does not have a string dependency link with the extension, meaning >> that uninstalling it won't impact the backward dependencies (so they >> are not really backward dependencies in that case :)). >> >> Now we need to decide what exactly is optional in Standard flavor. >> >> Here are some ideas: >> >> * application-help-center >> * xwiki-platform-menu-ui >> * xwiki-platform-wiki-ui-mainwiki >> > > this should be broken down so we could remove some stuff form there too, > like macro box or message > > >> * xwiki-platform-office-ui >> * xwiki-platform-invitation-ui >> * xwiki-platform-appwithinminutes-ui >> > > this might be core if we consider apps to be core, still on Website you > might not need to create AWM apps > > >> * xwiki-platform-linkchecker-ui >> * xwiki-platform-sandbox >> * xwiki-platform-sharepage-ui >> * xwiki-platform-distribution-flavor-tour >> * application-templates-ui >> > > what about the editors? maybe someone will want only the GWT one? or have > just wiki editor. I did not proposed CKEditor because GWT based one is still here only because we are lazy and we are supposed to ditch it ASAP and I tough it was not really the kind of thing you would uninstall (anyone can choose which editor he wants in his profile). > > It's a hard topic :) Not searching a perfect list just yet, just some obviously optional stuff that don't require heavy refactoring to be made optional. Others will be made optional on a case by case basic along the way. > > When we uninstall them, will this be reflected in the Active Installs? Yes (at least in term of data), Active Install send installed extensions with each ping. > Maybe finally we will see some differences between usage of the bundled > extensions. > > Anyway, great work Thomas. > > Thanks, > Caty > > >> >> I did not actually tried to uninstall those so it's possible it's not >> a good idea to uninstall some of them right now (hardcoded use >> somewhere maybe). >> >> WDYT ? >> >> -- >> Thomas Mortagne >> -- Thomas Mortagne
