+1 Guillaume
2018-01-15 13:57 GMT+01:00 Marius Dumitru Florea < mariusdumitru.flo...@xwiki.com>: > +1 > > Thanks, > Marius > > On Mon, Jan 15, 2018 at 2:55 PM, Thomas Mortagne < > thomas.morta...@xwiki.com> > wrote: > > > This plugin is part of Maven project itself and state that "The > > Failsafe Plugin is designed to run integration tests while the > > Surefire Plugin is designed to run unit tests" so indeed it looks like > > the right move :) > > > > +1 > > > > On Mon, Jan 15, 2018 at 1:36 PM, Vincent Massol <vinc...@massol.net> > > wrote: > > > Hi devs, > > > > > > We’ve been using the surefire plugin from the beginning even for > > functional tests. > > > > > > However it would be more correct to use the failsafe plugin for > > functional tests since this allows to perform some actions if a test > fails > > (like stopping XWiki - Note that right now this is not affecting us since > > we start/stop XWiki from Java so we’ve implemented this behavior > ourselves). > > > > > > I need this for using the fabric8 docker plugin for ex so that if some > > functional test fails the docker containers will be stopped. > > > > > > Ok with everyone? > > > > > > For reference: http://maven.apache.org/surefire/maven-failsafe-plugin/ > > > > > > Thanks > > > -Vincent > > > > > > > > > > > -- > > Thomas Mortagne > > > -- Guillaume Delhumeau (guillaume.delhum...@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
