Hi, We forgot to document it so I’ve put it at http://dev.xwiki.org/xwiki/bin/view/Community/DevelopmentPractices#HRule:Assigncontributorwhenthere27saPullRequest
Also note that several use cases were missing so I’ve added some too, please verify they’re ok for you: * no jira account * substantial rewrite of the PR Thanks -Vincent > On 2 Dec 2014, at 12:52, Ecaterina Moraru (Valica) <[email protected]> wrote: > > Hi, > > Vote 1: Contributor received 5 +1 binding, and 1 +1 non binding votes. > > Thanks for your votes. > > > On Wed, Nov 26, 2014 at 7:39 PM, Sergiu Dumitriu <[email protected]> wrote: > >> +1 for 1. >> >> On 11/26/2014 08:21 AM, Ecaterina Moraru (Valica) wrote: >>> Hi, >>> >>> We have discussed this subject multiple times, but we don't have an >>> official vote and conclusion on the topic. >>> >>> Problem: In JIRA who is the Assignee of an issue fixed by a Pull Request? >>> 1: Contributor >>> - he provided the solution >>> - giving the attributions, the contributor might feel encouraged to >>> contribute more >>> - we could do some JIRA statistics on external contributions, but this >> use >>> case can be covered by GitHub statistics >>> >>> 2: Committer >>> - he does the merging on his account and he becomes responsible for the >>> committed code. >>> - in case there are problems, the committer needs to find solution, since >>> we can't rely on contributors availability >>> - in doing the PR review, the committer spends a lot of time analyzing >> and >>> testing the provided solution >>> >>> We are talking here about complete solutions provided by the PR, since in >>> case of partial solutions, the committer can assign himself on the issue >>> (depends on the quantity of modification he does). >>> >>> Let me know what you think, >>> Caty >> >> -- >> Sergiu Dumitriu >> http://purl.org/net/sergiu >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs >> > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs
