Just a small note: there is also an edge case where JIRA is showing that the PR has been Merged, but we actually ended up REVERTING the contribution. Examples: https://jira.xwiki.org/browse/XWIKI-10606 or https://jira.xwiki.org/browse/XWIKI-106
On Tue, Aug 14, 2012 at 11:07 PM Sergiu Dumitriu <ser...@xwiki.com> wrote: > On 08/09/2012 06:23 AM, Ludovic Dubost wrote: > > Hi devs, > > > > I don't think there is currently a process that is in place to handle > > pull requests and I have the feeling that the way there are handled > > today is a bit random. > > There are usually comments sent out on each pull request but sometimes > > it seems that some pull requests are going in sleep mode and it's not > > clear who is in charge. > > > > I would like to suggest that a process is put in place where it's > > clear who is responsible for a pull request and a status is given to > > the contributors that propose that pull request. > > > > Something like: > > > > Assigned developer: XXXX > > For this there's a field on GitHub. A committer should assign himself on > the pull requests that's in his area of expertise. > > > Status: > > New -> new pull request, not yet assigned > > Assigned -> assigned to a developer, he is in charge of reviewing the > > pull request and ask for modifications or accept it. The developer can > > auto assign it to himself. If nobody does, we need to decide how they > > will be taken into account. > > ModificationsRequired -> for now rejected with comments. Contributor > > needs to apply comments and then change back to Assigned for further > > evaluation > > VoteRequired -> there are no more comments, but a vote is required as > > the changes to XWiki core are important > > WaitingFinalAuthorization -> optional step for complex patches where > > a additional authorization would be required (need to define who would > > be the persons that give the authorization) > > WaitingApplication -> there are no more comments and no changes or > > vote required. The pull request can be applied and is waiting for a > > developer to apply it > > Abandoned -> contributors is abandoning the pull request (cannot do > > the changes, no more time, etc..) > > Rejected -> pull request is rejected (quality not enough, etc..) > > Applied -> pull request is applied > > This is a bit too fine-grained for my taste, it's looking a bit too > corporate, too rigid. I prefer what Vincent has been doing on Jira, with > a two-state field: > > - waiting for committer feedback > - waiting for contributor feedback > > > What do you think ? > > > > Ludovic > > > > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > _______________________________________________ > devs mailing list > devs@xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs >
