On Mon, 1 Feb 1999, Alexander Larsson uttered the following:
> On 31 Jan, Lars R. Clausen wrote:
>>
>> This diff gives defaults dialogs for boxes, ellipses and text, and makes
>> the arrows for arc behave reasonably (though there might be room for
>> improvement). There's also some include file changes for gtk 1.1.14,
>> and a few old things that still reside in my copy of the source.
>
> Ok, i applied most of this. Some thunks are not applied.
> Also, it would be nice with a ChangeLog entry in the patches.
>
> Here are the unapplied parts of the patch with comments.
> (Don't take these comments in a bad way, i'm just a bit anal about
> keeping the tree as clean as possible. As i have to maintain it.)
I can understand that. You're getting a lot of diffs right now. I'll try
to weed them out a bit.
> Index: app/properties.c
> ===================================================================
> RCS file: /cvs/gnome/dia/app/properties.c,v
> retrieving revision 1.6
> diff -u -r1.6 properties.c
> --- properties.c 1999/01/16 13:20:12 1.6
> +++ properties.c 1999/02/01 05:24:43
> @@ -126,6 +126,3 @@
> current_dia = dia;
> }
>
> -
> -
> -
>
> ***** These kind of gratious whitespace changes are quite unneccesary
> ***** and might break other peoples diffs. Just remove them from the
> ***** patch.
Using -bB for diff should take care of that.
> Index: app/menus.c
> ===================================================================
> RCS file: /cvs/gnome/dia/app/menus.c,v
> retrieving revision 1.11
> diff -u -r1.11 menus.c
> --- menus.c 1999/01/25 13:24:17 1.11
> +++ menus.c 1999/02/01 05:24:43
> Index: app/menus.h
> ===================================================================
> RCS file: /cvs/gnome/dia/app/menus.h,v
> retrieving revision 1.3
> diff -u -r1.3 menus.h
> --- menus.h 1999/01/14 14:35:00 1.3
> +++ menus.h 1999/02/01 05:24:43
>
> ***** All these changes are obsoleted by the new object menu systems i
> ***** did. Just update these files to the version in cvs.
That's funny, I've been updating regularly. I'll keep a lookout for such
things and try an extra update if I see them again.
> Index: lib/message.c
> ===================================================================
> RCS file: /cvs/gnome/dia/lib/message.c,v
> retrieving revision 1.4
> diff -u -r1.4 message.c
> --- message.c 1999/01/16 13:20:15 1.4
> +++ message.c 1999/02/01 05:24:43
> @@ -32,8 +32,11 @@
> GtkWidget *dialog_window = NULL;
> GtkWidget *label;
> GtkWidget *button;
> + gint len;
>
> - gint len = format_string_length_upper_bound (fmt, args);
> + vfprintf(stderr, fmt, args);
> +
> + len = format_string_length_upper_bound (fmt, args);
>
> if (len >= alloc) {
> if (buf)
>
> ***** While i understand that this might be nice when debugging, i
> ***** don't think it should be in cv for the general user.
I'm not quite happy about error messages only going to a window (in fact, I
as a user would much rather have them go only to the console), especially
after I had the incident of a bug in the error messages (caused by faulty
installation on my part).
-Lars
--
Lars R. Clausen ([EMAIL PROTECTED])
A *real* smart bomb would call in sick, perhaps move to another country,
changing its name in the process, open a beach bar maybe and live out its
days in safe anonymity. -- Barry O'Neill in rhod
