On 2 Mar 1999, Lars R. Clausen wrote:
> On Tue, 2 Mar 1999, Alexander Larsson uttered the following:
> > On 1 Mar 1999, Lars R. Clausen wrote:
> >> I've started working on this. I've changed these files already to only
> >> use one properties dialog per kind, so let my patch grow a bit:) This
> >> implied having DEFAULT_{ARROW,LINESTYLE,FG_COLOR,...} -- I've put that
> >> in widgets.h so far, but is that really the place it should be?
> >
> > Um? Exactly what do you mean? What is DEFAULT_ARROW? Is it a define? or a
> > variable? widget.h hardly seems to be the best place.
>
> That would be a define. It's basically the arrow type that the _load
> routines should assume when they don't find any arrow data.
I don't really like this. Changing a define which seemingly changes only
what the default arrow-type for newly created objects is breaks the
file-format. I'd say, keep the defines, but use them only when creating
new objects. Then hardcode the default values in the object load and save
methods so that breaking the loading and saving is only done on purpose.
Also we must make sure all newly added data in objects have a default
value (when that data is missing) what keeps the 'old' meaning so that we
have backwards file compatibility.
/ Alex
