On 02/09/2017 04:49 AM, Walter Bright wrote:
On 2/8/2017 11:09 PM, Nick Sabalausky wrote:
And any PRs I have managed to get through were all uphill battles the
whole way.
You have contributed 5 PRs to dmd:
https://github.com/dlang/dmd/pulls?q=is%3Apr+author%3Aabscissa
1 is open (it's controversial)
1 closed (today by me)
Well, I suppose I brought that one on myself by complaining about it
being ignored :/
3 merged
1 in 6 days
2 in 1 day
Overall, I think you've done well.
Note that those quickly merged ones were several years ago, back before
the battles to get anything accepted reached ridiculous levels.
In any case, shouldn't it be an uphill battle to merge things?
No. There should be appropriate checks and reviews, yes. But, no, every
little fix and improvement shouldn't feel like trying to get somewhere
in a year-long tabs vs spaces debate or making a big-budget sales pitch
to Indecisives Anonymous.
