On 01/26/2018 09:43 PM, Fra Mecca wrote:
Real world case: this bug has been reported recently: https://issues.dlang.org/show_bug.cgi?id=18288#add_comment
[...]
From a quick glance at the phobos repo, I found no mention of this bug in any closed or open PR, just a PR (#6056, bug 18280) on the same file (comparison.d) that probably fixed the issue for bug 18288.
The issue is actually referenced on the page of PR #6056, in the comment by dlang-bot. The check marks in the "auto-close" column indicate that the issues should have been closed when the PR was merged. But apparently only the first one was actually closed. This might be a bug in dlang-bot.
I've filed an issue on the bot: https://github.com/dlang-bots/dlang-bot/issues/175
What should I do now? I am undecided between: - commenting on the bug tracker and close the bug - link the pr 6056 on the bug tracker - leaving it be
When you can point to the PR that fixed an issue, close the issue as RESOLVED FIXED and leave a comment pointing to the PR. Something along the lines of "Fixed by https://github.com/dlang/phobos/pull/6056";.
When you don't know what fixed an issue, you can close as RESOLVED WORKSFORME. But make sure that you've taken all the necessary steps to reproduce the issue: operating system, compiler flags, etc.
In both cases, it's great when you can make a PR that adds a test to the suite, ensuring that the issue doesn't come back. PR #6056 already adds the tests (as far as I see), so that's not needed here.
