On 05/11/2015 08:48 PM, Andrei Alexandrescu wrote:
On 5/11/15 11:31 AM, Timon Gehr wrote:
- The assertion in line 141 may fail. (expand can return false.)
OK, it seems the previous commit should take care of that.
...
Nope.
Well, yes, in the sense that there is no longer a possibly failing
assertion on line 141.
In any case, 'allocate' within 'expand' may fail, and if it does, b.ptr
will still be null throughout the body of reallocate/alignedReallocate.
- 'expand' ought to call 'allocate' when passed an empty buffer in case
the parent does not define 'expand', no?
Yah, in fact it suffices to call allocate() whether or not the parent
defines expand(). So I did so in
https://github.com/andralex/phobos/commit/9307b9f8969b7bfd0906e0441a13cbbded7f8418.
OK.
