On Friday, 24 August 2018 at 03:06:40 UTC, Jonathan Marler wrote:
I don't have much influence on the first 4 types of "leverage
points" in D, but I have a suggestion for a new "rule of the
system" (5th most important type of leverage point). Require
reviews from any user before merging their pull requests.
There's a number of ways you could implement the requirement,
maybe every PR that a user creates needs to have at least 1
review of another PR associated with it. You could require
more or less reviews depending on the size of the PR queue.
You could also look at developer's "review to pull request"
ratio.
Interesting idea.
Just to get an idea, I wrote a script to calculate some of this
data (github.com/marler8997/githubstats). Here's the data for
dmd, sorted by review to pr ratio:
[…]
Interesting data as well. Seeing that relatively few have a
review/pr ratio > 1, you may be onto something.
(The list seems to have an issue with ordering though, for those
that reviewed without having PRs. Attributing them a ratio of > 1
would be fairer than 0).
