On Thu, 03 Mar 2011 20:19:52 -0000, Andrei Alexandrescu
<seewebsiteforem...@erdani.org> wrote:
On 3/3/11 2:08 PM, Walter Bright wrote:
Regan Heath wrote:
Ok, found the original code. How do I go about submitting it to phobos?
Thanks!
I suggest:
1. Join the phobos mailing list
2. Propose package and module names
3. Fork https://github.com/D-Programming-Language/phobos
4. Check your original code into your fork under those package and
module names
5. Develop them!
6. Issue pull requests
I'm a newbie with github, but I think that is the correct workflow.
Correct me if I'm wrong!
That's the technical part of it. The bulk of the process is making a
proposal on this group and having the design, implementation, and
documentation discussed and improved following feedback.
If Regan does not have the time to commit to such, he could donate the
code to someone else to take it through this process. Alternatively, if
some components are small enough and of obvious value they can be
adopted without going through a stringent process.
What definitely doesn't scale is Phobos acquiring unfinished pieces of
functionality, knocking them into shape, and subsequently maintaining
them. (Of course, it could happen that someone on the Phobos team does
that, but by doing so the member becomes the virtual owner of that
functionality.)
Ok.. I am on windows. So, I installed TortoiseGIT and msysgit 1.7.4.
Then I worked on the original code, make it compile with the latest D
compiler, fixed some big endian issues which were known but never
accounted for in the original code, fixed a bug where I was passing a
uint[8] and expecting modification to stick, whereas it now requires 'ref'
then I started adding comments for ddoc .. and ran into:
http://d.puremagic.com/issues/show_bug.cgi?id=5701
I thought perhaps I could resolve it myself by rebuilding druntime+phobos,
and when that made no difference I rebuilt dmd.. also to no avail. I
guess I can downgrade to a previous version and try that, but I have no
guarantee that will work. It's a bit annoying.
Anyway, assuming I have some code and some documentation do I just start a
new thread here and ask for comments?
I do currently have the spare time to whip these modules into shape, but I
cannot guarantee I will have the time to maintain them indefinitely if
that is required?
R
--
Using Opera's revolutionary email client: http://www.opera.com/mail/
