On 6/6/2011 4:56 AM, simendsjo wrote:
I have very limited experience with D and haven't taken the time to understood
the code, but here are
some easy nitpicks :)
----
imports: Should stuff in core really depend on phobos? Isn't much of the reason
for core to allow
different "standard" libraries like tango?
177: should 16 be alignBytes?
Yes. Good catch.
199/299: unnecessary initializers
I prefer to have this explicit in cases where I will actually use the
zero value.
246: Move inUse.destroy() up to clearing of inUse?
Good idea.
291: Move assumption comment to assertion. Something like this:
Good idea. This can be implemented even more easily for powers of two:
import core.bitop;
bool isPowerOfTwo(size_t num) {
return bsr(num) == bsf(num);
}
383/408/418/428: getState called without () (deprecated behavior, right..?)
Unfortunately, yes.
686: missing () (same as above)
Argh. Can we **__PLEASE__** go with loose semantics for @property?
