On Monday, August 15, 2011 17:54 Brad Roberts wrote: > On Mon, 15 Aug 2011, Walter Bright wrote: > > On 8/14/2011 11:48 AM, Brad Roberts wrote: > > > google --> git pre-commit hook > > > > > > Setup whatever sort of checks you want on your local repository and > > > it'll be correct before pushing to github to even get into a pull > > > request. > > > > Just be sure and not check the .mak files - they'll choke if the tabs are > > converted to spaces. > > Check != change. > > You _could_ setup auto-changing as well, but that's a different game > altogether.
True, but you'd still want to avoid checking them since presumably if you're checking for tabs, you're blocking commits which include them, and in this case, you actually need them (which is a very bad design decision for make IMHO, but whatever - that's a whole other issue), so blocking them would cause problems. And even if you're just setting up checks with no blocks (just warnings or whatever), you still probably wouldn't want makefiles checked for tabs, since you'd be getting warnings about them every time that you changed them. - Jonathan M Davis
