On Mon, 09 Jul 2012 12:24:12 -0700, Jonathan M Davis <[email protected]>
wrote:
On Monday, July 09, 2012 10:01:25 Andrei Alexandrescu wrote:
On 7/9/12 3:52 AM, Jonathan M Davis wrote:
> On Sunday, July 08, 2012 23:37:29 Adam Wilson wrote:
>> First I want to mention two people who really helped make this day
>> happen.
>
> Andrei is the one who was doing most of the work by reviewing and
merging
> most of the pull requests which got merged.
Giving me credit for this is like giving credit the cable for
electricity. I just let the great work of others flow.
It's a team effort, but the processing of pull requests has been a
definite
bottleneck. I'd say that for Phobos, 90+% of the time it's either you or
me
who merges them, so if either of us is slow about it and/or another
Phobos dev
is needed to review a particular request, then pull requests tend to
languish.
It's even worse for druntime, since a lot of the time, Sean needs to get
involved (particularly since some of us feel a bit unqualified reviewing
and
merging some of the critical stuff in druntime), and he seems to be
very, very
busy (though with Martin Nowak recently added as a committer for
druntime, the
situation may improve). So, the fact that you took the time to review and
merge so many pull requests had a big impact.
- Jonathan M Davis
When I mentioned this post on IRC he specifically requested to be left out
of it. So I did. However, I personally feel that his willingness to get in
there and swing his +50 Hammer of Merging did in fact have a big impact on
the successes of yesterday.
--
Adam Wilson
IRC: LightBender
Project Coordinator
The Horizon Project
http://www.thehorizonproject.org/