On Wed, Nov 07, 2018 at 12:39:03PM +0200, Ville Syrjälä wrote:
> On Tue, Nov 06, 2018 at 04:03:50PM -0800, Rodrigo Vivi wrote:
> > Or we have the risk of getting tricked out by
> >
> > "Suggested-by:"
> >
> > Like we were on kernel commit 35b876db4a42 ("drm/i915/dsc:
> > Add slice_row_per_frame in DSC PPS programming"
>
> Yeah, seems good to make this really explicit. Even a minor typo might
> annoy other tools that check for this.
>
> Reviewed-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
pushed with irc ack from Daniel.
Thanks,
Rodrigo.
>
> >
> > Reference:
> > https://lists.freedesktop.org/archives/intel-gfx/2018-November/181151.html
> > Cc: Stephen Rothwell <s...@canb.auug.org.au>
> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
> > Cc: Jani Nikula <jani.nik...@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.v...@intel.com>
> > ---
> > dim | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/dim b/dim
> > index 1fc40ef15317..3d6548568b56 100755
> > --- a/dim
> > +++ b/dim
> > @@ -795,13 +795,13 @@ function checkpatch_commit_push
> > author_outlook=$(git show -s $sha1 --format="format:%an" | sed -e
> > 's/\([^ ]*\) \(.*\)/\2, \1/')
> >
> > # check for author sign-off
> > - if ! git show -s $sha1 | grep -qi
> > "S.*-by:.*\\($author\\|$author_outlook\\)" ; then
> > + if ! git show -s $sha1 | grep -qi
> > "Signed-off-by:.*\\($author\\|$author_outlook\\)" ; then
> > echoerr "$sha1 is lacking author of sign-off"
> > rv=1
> > fi
> >
> > # check for committer sign-off
> > - if ! git show -s $sha1 | grep -qi "S.*-by:.*$committer" ; then
> > + if ! git show -s $sha1 | grep -qi "Signed-off-by:.*$committer" ; then
> > echoerr "$sha1 is lacking committer of sign-off"
> > rv=1
> > fi
> > --
> > 2.19.1
> >
> > _______________________________________________
> > dim-tools mailing list
> > dim-tools@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dim-tools
>
> --
> Ville Syrjälä
> Intel
_______________________________________________
dim-tools mailing list
dim-tools@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dim-tools
