On Thu, Jan 10, 2019 at 03:28:27PM +0200, Jani Nikula wrote: > Ignore the bool member warning for drm-intel: > > CHECK:BOOL_MEMBER: Avoid using bool structure members because of > possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
Might be usuful to also link to our own threads about why this isn't quite so much black&white. > > For most of our use cases having the compiler DTRT without explicit !! > is preferrable, even at the cost of the relatively small space waste. > > Signed-off-by: Jani Nikula <[email protected]> Reviewed-by: Daniel Vetter <[email protected]> > --- > dim | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dim b/dim > index 9b20154d0c92..1efbffd7c677 100755 > --- a/dim > +++ b/dim > @@ -1547,7 +1547,7 @@ function checkpatch_commit > profile_options="" > ;; > drm-intel) > - profile_options="--max-line-length=100 > --ignore=BIT_MACRO,PREFER_KERNEL_TYPES,SPLIT_STRING,LONG_LINE_STRING" > + profile_options="--max-line-length=100 > --ignore=BIT_MACRO,PREFER_KERNEL_TYPES,SPLIT_STRING,LONG_LINE_STRING,BOOL_MEMBER" > ;; > *) > echoerr "Unknown checkpatch profile $profile" > -- > 2.20.1 > > _______________________________________________ > dim-tools mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/dim-tools -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dim-tools mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dim-tools
