On Fri, Jan 11, 2019 at 3:16 PM Jani Nikula <[email protected]> wrote: > > On Fri, 11 Jan 2019, Daniel Vetter <[email protected]> wrote: > > On Fri, Jan 11, 2019 at 12:50:38PM +0200, Jani Nikula wrote: > >> On Fri, 11 Jan 2019, Daniel Vetter <[email protected]> wrote: > >> > On Fri, Jan 11, 2019 at 11:26:11AM +0200, Jani Nikula wrote: > >> >> The pull requests are more than just FYI for Daniel nowadays. > >> >> > >> >> Cc: Daniel Vetter <[email protected]> > >> >> Signed-off-by: Jani Nikula <[email protected]> > >> > > >> > Reviewed-by: Daniel Vetter <[email protected]> > >> > >> Thanks, pushed. > >> > >> > Still wondering whether we could look up the corresponding MAINTAINERS > >> > entry for the upstream git repo we picked and automate this a bit more > >> > ... > >> > >> We can get all the relevant names and lists (*) with: > >> > >> $ get_maintainer --no-rolestats --pattern-depth 1 -f drivers/gpu/drm -f > >> drivers/gpu/drm/i915 > >> > >> The question is, do we care about the To/Cc distinction in the pull > >> request mails? drm vs. drivers is easy, drm vs. drm-misc is not, unless > >> we fabricate some things in MAINTAINERS that are specific to each. > > > > What I had in mind was: > > 1. convert the remote to an url > > 2. search maintainers for that git url > > 3. for all the entries that match, grab the M: fields > > > > Do this both for the target of the url (goes into To:) and the branch you > > send the pull request for (goes into Cc:). Additionally we could Cc: all > > the L: entries too. > > > > This would even work for sending drm-next/-fixes pulls to Linus, since > > he's got an entry for his tree in MAINTAINERS (including L: lkml). Plus it > > would automatically dtrt thing for topic pull requests to other trees. > > > > The only reason I have't done this yet is that it'd be real typing, since > > get_maintainers.pl can search by git repo ... > > ITYM can't search. Yup.
> It's not just typing, it's also climbing over the Bikeshed Mountain with > get_maintainer.pl changes... Well I figured it's easier to type more and bikeshed less, i.e. copy half of get_maintainers.pl into dim. Because I don't want to climb that bikeshed mount, not after your attempts :-/ -Daniel > > BR, > Jani. > > > -Daniel > > > >> > >> BR, > >> Jani. > >> > >> > >> (*) except dim-tools, but I think we can drop that anyway > >> > >> > -Daniel > >> > > >> >> --- > >> >> dim | 2 +- > >> >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> >> > >> >> diff --git a/dim b/dim > >> >> index dafbf946e0b7..76afd2fbec6f 100755 > >> >> --- a/dim > >> >> +++ b/dim > >> >> @@ -81,7 +81,6 @@ > >> >> maintainer_tools_https=https://gitlab.freedesktop.org/drm/maintainer-tools.git > >> >> # Recipients for all dim based pull requests. > >> >> # Add To: lines to the end, Cc: lines in the beginning with -c. > >> >> dim_pull_request_recipients=( > >> >> - -c "Daniel Vetter <[email protected]>" > >> >> -c "Jani Nikula <[email protected]>" > >> >> -c "Joonas Lahtinen <[email protected]>" > >> >> -c "Rodrigo Vivi <[email protected]>" > >> >> @@ -92,6 +91,7 @@ dim_pull_request_recipients=( > >> >> -c "[email protected]" > >> >> -c "[email protected]" > >> >> "Dave Airlie <[email protected]>" > >> >> + "Daniel Vetter <[email protected]>" > >> >> ) > >> >> > >> >> # integration configuration > >> >> -- > >> >> 2.20.1 > >> >> > >> > >> -- > >> Jani Nikula, Intel Open Source Graphics Center > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dim-tools mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dim-tools
