On Mon, 05 Aug 2019, Arkadiusz Hiler <arkadiusz.hi...@intel.com> wrote: > On Fri, Aug 02, 2019 at 04:15:26PM +0300, Jani Nikula wrote: >> On Fri, 02 Aug 2019, Jani Nikula <jani.nik...@linux.intel.com> wrote: >> > On Fri, 05 Jul 2019, Arkadiusz Hiler <arkadiusz.hi...@intel.com> wrote: >> >> If patch happens to move lines around it's easy to end in a situation >> >> where we end up with errors just moving around: >> >> >> >> -error1:123 >> >> error2:124 >> >> +error1:125 >> >> >> >> With remapping, sorting and then diffing without context we end up with: >> >> -error1:123 >> >> +error1:123 >> >> >> >> Which is quite confusing and should not generate warning in the first >> >> place. >> >> >> >> This can be fixed by sorting the lines *after* the remapping. >> > >> > Pushed, thanks for the patch, and sorry for the delay. >> > >> > These are some of the more confusing lines for me in dim... >> >> PS. dim sparse hangs if there are any config changes that require user >> input. >> >> >> BR, >> Jani. > > Oh. Thanks for reporting it. > > Since it's heavliy used by CI one of the available behaviors should be > "make olddefconfig" which is quite trivial to add. Do you see any value > in being prompted by "make oldconfig" to make the choices yourself?
With dim, never. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
