On Thu, Sep 17, 2020 at 10:49 AM Maxime Ripard <[email protected]> wrote: > > Hi Daniel, > > On Sun, Aug 30, 2020 at 08:07:17AM +0200, Daniel Vetter wrote: > > On Tue, Aug 25, 2020 at 3:35 PM Maxime Ripard <[email protected]> wrote: > > > > > > When creating a PR the current code will try to validate the whole range > > > of > > > commits between the upstream and the branch we want to create a PR for. > > > > > > However, if we have merged a tag that isn't in the upstream yet, we will > > > validate the range between upstream and that tag as well, even though it's > > > very likely to not follow our rules. > > > > > > Let's make sure we only consider the first parent, and thus our branch. > > > > > > Signed-off-by: Maxime Ripard <[email protected]> > > > > But this misses stuff when you pull in topic branches, which generally > > should follow our rules. So if this has been just because of the > > backmerge I'd leave it as-is, if some topic branch from a non-drm > > maintainer upset things, I guess maybe need to reconsider. > > I guess we can :) > > The virtio PR I merged earlier this week is in the same situation
Hm ok, I guess we can rely on maintainers checking pulls when merging ... Acked-by: Daniel Vetter <[email protected]> -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dim-tools mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dim-tools
