On Mon, Oct 03, 2022 at 11:50:19AM -0700, Daniele Ceraolo Spurio wrote: > The check_maintainer warns the user if any of the patches being applied > touches files outside of the ones that are owned by the branch that the > patches are being applied to. > The only branch currently covered by the checks is drm-intel-next, but > checking for i915 paths is good practice for all intel branches, so > extend the check to cover them all. > > Signed-off-by: Daniele Ceraolo Spurio <[email protected]> > --- > dim | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dim b/dim > index 4b43bf8..1256798 100755 > --- a/dim > +++ b/dim > @@ -1701,7 +1701,7 @@ function check_maintainer > branch=$1 > commit=$2 > > - if [ "$branch" = "drm-intel-next" ]; then > + if [[ "$branch" = "drm-intel-"* ]]; then
we probably need to 'or' with drm-intel-gt-next... no one except maintainers should be pushing to any other drm-intel-* branch other than these 2. and if we don't have this check in place already it is probably worth to add an extra check for the fixes branch?! > if non_i915_files=$(git diff-tree --no-commit-id --name-only -r > $commit | \ > grep -v > "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\|Documentation/gpu/i915\)") > && [[ -n "$non_i915_files" ]]; then > echo -e "The following files are outside of i915 > maintenance scope:\n" > -- > 2.37.3 >
