Hi, On Sat, Jul 05, 2025 at 11:03:28AM +0200, Lukas Wunner wrote: > On Fri, Mar 01, 2024 at 01:58:25PM +0100, Maxime Ripard wrote: > > We've recently had multiple occurences of people taking patches through > > the drm-misc tree for parts of the kernel that aren't under drm-misc > > maintenance, and without the maintainers Ack. > > > > While merging patches on behalf of someone else is totally something we > > can do, we need to tell the maintainer and make sure he's fine with > > that. > > > > This patch adds some logic to detect if the the range of commits belong > > indeed to the branch we are currently working on, and if not check for > > the maintainer's Acked-by or Signed-off-by. > > This was pushed to maintainer-tools yesterday and immediately tripped me > up when trying to push a commit amending MAINTAINERS: > > https://lore.kernel.org/r/[email protected] > > That's because... > > git show HEAD | \ > scripts/get_maintainer.pl --no-git-fallback -m --nol --norolestats > > ...returns nothing. > > I had to cheat by inserting a "return 0" in checkpatch_maintainer(). > > I think we either need to return 0 if the command returns nothing > (i.e. no known maintainers) or we need a whitelist for certain files.
My initial thought was that making an exception for MAINTAINERS would probably be better in corner cases, but I can't think how to implement it properly, so maybe just returning if the commande returns nothing is the right path. Can you send a patch to implement the latter? Maxime
signature.asc
Description: PGP signature
