Quoting Antonino Daplas ([EMAIL PROTECTED]): > Hi, > > I would like to have the gfxdriver driver I'm writing for the i810/i815 > chipset reviewed. Since there's no official i810 framebuffer driver yet > included in the kernel, I had to write an i810 framebuffer driver as > well. Using a generic gfxdriver in software fallback mode and the i810fb > driver, all the examples, gtk-demo and DFPoint work okay.
Great work, a friend has an i810 on-board and I hope to test it this weekend. I had a quick look at the attached source, looks clean. There's only one thing so far that needs to be changed. SetState is called before operations if 'state->modified' is non-zero or if 'state->set' does not contain the bit passed via 'accel'. So you should clear the bit in 'state->modified' after programming the specific entry. In addition you should OR the 'accel' into 'state->set'. These changes will affect the performance of the driver. I will give you more feedback after testing the driver(s). -- Best regards, Denis Oliver Kropp .------------------------------------------. | DirectFB - Hardware accelerated graphics | | http://www.directfb.org/ | "------------------------------------------" convergence integrated media GmbH -- Info: To unsubscribe send a mail to [EMAIL PROTECTED] with "unsubscribe directfb-dev" as subject.
